feat(react19): Remove findDomNode in textCopyInput #82637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
reviewed
Dec 30, 2024
| // it's a ref to AutoSelectText | ||
| const node = findDOMNode(textRef.current); // eslint-disable-line react/no-find-dom-node | ||
| if (!node || !(node instanceof HTMLElement)) { | ||
| const node = document.getElementById(textNodeId); |
There was a problem hiding this comment.
getElementById might meant that the else case below isn't needed anymore... it should always be an HTMLInputElement .... unless the <StyledInput> implementation changes...
ryan953
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of https://github.com/getsentry/frontend-tsc/issues/68