Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(replay): add collapsible row to mobile tags #82740

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Dec 30, 2024

  • display the mobile redact classes in a prettier format by using CollapsibleValue.
  • kept the tooltip on overflow since we can't scroll the value

before:

SCR-20241230-qhjv

after:

Screen.Recording.2024-12-30.at.6.40.15.PM.mov

@michellewzhang michellewzhang requested a review from a team as a code owner December 30, 2024 23:44
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 30, 2024
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #82740      +/-   ##
==========================================
- Coverage   87.50%   84.58%   -2.92%     
==========================================
  Files        9407     9405       -2     
  Lines      536681   536492     -189     
  Branches    21045    21044       -1     
==========================================
- Hits       469596   453816   -15780     
- Misses      66717    82308   +15591     
  Partials      368      368              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants