🔧 chore: remove redundant slack logging & metrics

[iamrajjoshi]

we have completed the audit of our integration slos, so going back and cleaning up redundant logging and metrics.

we should also monitor our DD monitors to see if they need updating.

[codecov]

❌ 3 Tests Failed:

Tests completed	Failed	Passed	Skipped
23468	3	23465	214

View the top 3 failed tests by shortest run time

tests.sentry.integrations.slack.service.test_slack_service.TestHandleParentNotification::test_handles_parent_notification_sdk

Stack Traces | 2.73s run time

#x1B[1m#x1B[.../slack/service/test_slack_service.py#x1B[0m:255: in test_handles_parent_notification_sdk
    assert_slo_metric(mock_record, EventLifecycleOutcome.SUCCESS)
#x1B[1m#x1B[.../sentry/testutils/asserts.py#x1B[0m:93: in assert_slo_metric
    assert len(mock_record.mock_calls) == 2
#x1B[1m#x1B[31mE   AssertionError: assert 0 == 2#x1B[0m
#x1B[1m#x1B[31mE    +  where 0 = len([])#x1B[0m
#x1B[1m#x1B[31mE    +    where [] = <MagicMock name='record_event' id='140232433138096'>.mock_calls#x1B[0m

tests.sentry.integrations.slack.service.test_slack_service.TestHandleParentNotification::test_handles_parent_notification_sdk_error

Stack Traces | 2.83s run time

#x1B[1m#x1B[.../slack/service/test_slack_service.py#x1B[0m:269: in test_handles_parent_notification_sdk_error
    assert_slo_metric(mock_record, EventLifecycleOutcome.FAILURE)
#x1B[1m#x1B[.../sentry/testutils/asserts.py#x1B[0m:93: in assert_slo_metric
    assert len(mock_record.mock_calls) == 2
#x1B[1m#x1B[31mE   AssertionError: assert 0 == 2#x1B[0m
#x1B[1m#x1B[31mE    +  where 0 = len([])#x1B[0m
#x1B[1m#x1B[31mE    +    where [] = <MagicMock name='record_event' id='140232433023648'>.mock_calls#x1B[0m

tests.sentry.integrations.slack.service.test_slack_service.TestNotifyAllThreadsForActivity::test_calls_handle_parent_notification_sdk_client

Stack Traces | 2.83s run time

#x1B[1m#x1B[.../slack/service/test_slack_service.py#x1B[0m:176: in test_calls_handle_parent_notification_sdk_client
    assert_slo_metric(mock_record, EventLifecycleOutcome.SUCCESS)
#x1B[1m#x1B[.../sentry/testutils/asserts.py#x1B[0m:93: in assert_slo_metric
    assert len(mock_record.mock_calls) == 2
#x1B[1m#x1B[31mE   AssertionError: assert 4 == 2#x1B[0m
#x1B[1m#x1B[31mE    +  where 4 = len([call(<EventLifecycleOutcome.STARTED: 'STARTED'>),\n call(<EventLifecycleOutcome.SUCCESS: 'SUCCESS'>, None),\n call(<EventLifecycleOutcome.STARTED: 'STARTED'>),\n call(<EventLifecycleOutcome.SUCCESS: 'SUCCESS'>, None)])#x1B[0m
#x1B[1m#x1B[31mE    +    where [call(<EventLifecycleOutcome.STARTED: 'STARTED'>),\n call(<EventLifecycleOutcome.SUCCESS: 'SUCCESS'>, None),\n call(<EventLifecycleOutcome.STARTED: 'STARTED'>),\n call(<EventLifecycleOutcome.SUCCESS: 'SUCCESS'>, None)] = <MagicMock name='record_event' id='140307752261760'>.mock_calls#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

[iamrajjoshi]

diff is weird here, but basically we don't catch the SlackAPI in this function, rather the callee function above.