fix(data-secrecy): update fe state & address a couple bugs #82756
Conversation
github-actions
bot
added
the
Scope: Frontend
|
|
||
| // if the user has allowed access, we need to remove the temporary access window | ||
| // only if there is an existing waiver | ||
| if (value && allowData) { |
There was a problem hiding this comment.
problem 1 - if a user has a waiver set then allows access, we should delete the waiver. this is because after a while if the user turns out data secrecy again, we don't want them to get surprised with the old waiver.
hence we delete, so when the user enables data secrecy, they start fresh and need to create a new waiver.
| data: nextData, | ||
| } | ||
| ); | ||
| await api.requestPromise(`/organizations/${organization.slug}/data-secrecy/`, { |
| disabled: allowAccess && !organization.access.includes('org:write'), | ||
| value: allowAccess ? '' : allowDateFormData, | ||
| // disable the field if the user has allowed access or if the user does not have org:write access | ||
| disabled: allowAccess || !organization.access.includes('org:write'), |
There was a problem hiding this comment.
this was a bug, we should disable the date input if data secrecy is disabled OR if the user doesn't have enough permissions
| @@ -140,9 +172,9 @@ export default function DataSecrecy() { | |||
| <PanelBody> | |||
| {!allowAccess && ( | |||
| <PanelAlert> | |||
| {hasValidTempAccess | |||
| {allowData?.accessEnd && moment().isBefore(moment(allowData.accessEnd)) | |||
There was a problem hiding this comment.
hadValidTempAccess was a a constant which wasn't stateful, so just moved the stateful conditional here.
iamrajjoshi
force-pushed
the
raj/ds-waiver-fix-fe
branch
from
2525693 to
1c821b2
Compare
| const [allowDate, setAllowDate] = useState<WaiverData>(); | ||
|
|
||
| // state of the data secrecy waiver | ||
| const [allowData, setAllowDate] = useState<WaiverData>(); |
There was a problem hiding this comment.
naming nit: waiver, setWaiver?
| addSuccessMessage( | ||
| t('Successfully removed temporary access window and allowed support access.') | ||
| ); | ||
| // refetch to get the latest waiver data | ||
| refetch(); | ||
| return; | ||
| } | ||
| addSuccessMessage( | ||
| value | ||
| ? t('Successfully allowed support access.') | ||
| : t('Successfully removed support access.') | ||
| ); |
There was a problem hiding this comment.
nit: instead of early return you can modify the success message text, add the success message outside of the if, and then you can use the refetch at the end of the function
followup of #82754.
here, i am fixing some of the bugs i found while fixing the data secrecy waiver. i added comments where relevant. after this deploys, we should be ready to GA
video demo:
Screen.Recording.2024-12-30.at.11.11.50.PM.mov