feat(workflow-engine): add NewHighPriorityIssueConditionHandler
#82846
Conversation
github-actions
bot
added
the
Scope: Backend
| @@ -6,6 +6,18 @@ | |||
| from sentry.workflow_engine.types import DataConditionHandler, WorkflowJob | |||
|
|
|||
|
|
|||
| def is_new_event(job: WorkflowJob) -> bool: | |||
| comparison=True, | ||
| condition_result=True, | ||
| ) | ||
| self.group_event.group.priority = PriorityLevel.HIGH |
There was a problem hiding this comment.
should we use update() for all of these? i feel like it would be better if the DB state reflected the class state
There was a problem hiding this comment.
like self.group_event.group.update(priority=PriorityLevel.HIGH)
|
|
||
| # This will only pass for new issues | ||
| self.group_event.group.update(priority=PriorityLevel.HIGH) | ||
| self.job.update({"group_state": {"is_new_group_environment": True}}) |
There was a problem hiding this comment.
i think this needs to be self.job["group_state"]["is_new_group_environment"] = True. you can call update() because job is a dictionary, but mypy is complaining that group_state is missing some keys.
we should call update() for self.group_event.group because it's a Django model and we want to save the changes to the db
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #82846 +/- ##
==========================================
+ Coverage 84.84% 84.88% +0.03%
==========================================
Files 9410 9410
Lines 536845 536563 -282
Branches 21049 21049
==========================================
- Hits 455508 455467 -41
+ Misses 80865 80624 -241
Partials 472 472 |
add
NewHighPriorityIssueConditionHandler