ref: remove unused attachment_id column part 1 #82892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for --
-- Moved monitorcheckin.attachment_id field to pending deletion state
--
-- (no-op) |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #82892 +/- ##
===========================================
+ Coverage 45.27% 87.56% +42.29%
===========================================
Files 9407 9421 +14
Lines 535958 536625 +667
Branches 21119 21119
===========================================
+ Hits 242632 469907 +227275
+ Misses 292966 66358 -226608
Partials 360 360 |
asottile-sentry
force-pushed
the
asottile-remove-attachment-id-column
branch
from
ae8abf7 to
5dd9461
Compare
wedamija
approved these changes
Jan 7, 2025
asottile-sentry
force-pushed
the
asottile-remove-attachment-id-column
branch
from
5dd9461 to
9c00061
Compare
asottile-sentry
force-pushed
the
asottile-remove-attachment-id-column
branch
from
9c00061 to
b48019e
Compare
|
This PR has a migration; here is the generated SQL for --
-- Moved monitorcheckin.attachment_id field to pending deletion state
--
-- (no-op) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked on #82891