Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(widget-builder): Add error functionality to type selector #82958

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

nikkikapadia
Copy link
Member

Shows an error beside the widget type selector if there is an error. The way we have the widget builder set up right now there should be no error that arises however it's good to have the error indicator/message there anyways.

This is what it would look like if an error arises:
Screenshot 2025-01-06 at 4 07 43 PM

Contributes to #81729

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 6, 2025
@nikkikapadia nikkikapadia marked this pull request as ready for review January 6, 2025 21:36
@nikkikapadia nikkikapadia requested a review from a team as a code owner January 6, 2025 21:36
Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nikkikapadia nikkikapadia merged commit ace621b into master Jan 6, 2025
44 checks passed
@nikkikapadia nikkikapadia deleted the nikki/feat/widget-builder-type-error branch January 6, 2025 21:45
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #82958      +/-   ##
==========================================
- Coverage   87.56%   84.65%   -2.91%     
==========================================
  Files        9409     9407       -2     
  Lines      536869   536672     -197     
  Branches    21107    21105       -2     
==========================================
- Hits       470084   454297   -15787     
- Misses      66419    82009   +15590     
  Partials      366      366              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants