Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(streamline): Add an option to remove opt-out for new users #83205

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

leeandher
Copy link
Member

@leeandher leeandher commented Jan 9, 2025

Adds an option assigned to new organizations such that all members of the organization receive either the new UI or legacy UI without the ability to opt into one or the other.

This work doesn't actually do any of the UI enforcement, that will be in a correlated Frontend PR that needs to be merged first.

todo

  • Add some tests to ensure the options are set

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 93.18182% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/api/endpoints/organization_index.py 90.47% 2 Missing ⚠️
src/sentry/issues/streamline.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #83205       +/-   ##
===========================================
+ Coverage   63.42%   87.58%   +24.16%     
===========================================
  Files        4220     9463     +5243     
  Lines      129995   536924   +406929     
  Branches    21113    21113               
===========================================
+ Hits        82444   470286   +387842     
- Misses      47192    66279    +19087     
  Partials      359      359               

@leeandher leeandher marked this pull request as ready for review January 9, 2025 22:23
@leeandher leeandher requested a review from a team as a code owner January 9, 2025 22:23
@@ -494,6 +495,7 @@ class DetailedOrganizationSerializerResponse(_DetailedOrganizationSerializerResp
metricsActivateLastForGauges: bool
requiresSso: bool
rollbackEnabled: bool
streamlineOnly: bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be bool | None?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants