fix(eap-api): Sentry distinguishes floats and doubles #83629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #83629 +/- ##
==========================================
+ Coverage 87.57% 87.58% +0.01%
==========================================
Files 9492 9491 -1
Lines 539110 539306 +196
Branches 21218 21218
==========================================
+ Hits 472116 472345 +229
+ Misses 66645 66612 -33
Partials 349 349 |
xurui-c
force-pushed
the
rachel/alternative
branch
from
c02d5fe to
0c4fba3
Compare
xurui-c
force-pushed
the
rachel/alternative
branch
from
0c4fba3 to
574ebca
Compare
xurui-c
force-pushed
the
rachel/alternative
branch
from
574ebca to
aee739d
Compare
xurui-c
force-pushed
the
rachel/alternative
branch
from
aee739d to
5d10e2a
Compare
phacops
approved these changes
Jan 17, 2025
xurui-c
force-pushed
the
rachel/alternative
branch
from
5d10e2a to
f125fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #83566
Even when Snuba sends back doubles, Sentry uses
TYPE_MAPto resolve them into floats. This is unintended behavior. This PR makes it so that Sentry looks at Snuba's response to determine if the values are doubles, instead of looking atTYPE_MAPto determine that.