feat(nav): Stop using config for primary navigation #83666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
commented
Jan 17, 2025
| <Fragment> | ||
| <SidebarBody> | ||
| <SidebarItem | ||
| item={{ |
There was a problem hiding this comment.
Everything in this file was taken from sidebar.tsx except for the below items which used to be defined in a config file
scttcper
reviewed
Jan 17, 2025
Comment on lines
+112
to
+116
| if (!to) { | ||
| throw new Error( | ||
| `Nav item "${item.label}" must have either a \`dropdown\` or \`to\` value!` | ||
| ); | ||
| } |
There was a problem hiding this comment.
can this not be done via typescript
There was a problem hiding this comment.
Yeah, this was existing code. I'm getting rid of the item prop anyway, once I'm fully off the config you'll just render a link or dropdown depending on what you want
scttcper
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan is to stop using the config and just render items as JSX. This moves all the primary items in the config over to JSX. No behavior changes.