ref: improve links inside AddCodeOwnerModal #83672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd cannot have "undefined" in the path
github-actions
bot
added
the
Scope: Frontend
ryan953
commented
Jan 17, 2025
| @@ -292,7 +292,6 @@ function ErrorMessage({ | |||
| errorJSON: {raw?: string} | null; | |||
| }) { | |||
| const codeMapping = codeMappings.find(mapping => mapping.id === codeMappingId); | |||
| const {integrationId, provider} = codeMapping as RepositoryProjectPathConfig; | |||
There was a problem hiding this comment.
no need to force RepositoryProjectPathConfig type here, we have the codeMapping && guard, and typescript can understand the refinement if we type codeMapping.integrationId instead of destructuring.
ryan953
changed the title
scttcper
approved these changes
Jan 17, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
Link should have a trailing `/` and should not have "undefined" in any
path segment.
The way these links are constructed it's possible to have `/undefined/`
inside the url because of the optional types involved. This change makes
the types slightly better in the `*MappingLink` fields, and will return
empty string instead of `"undefined"` if needed.
The url that these links point to is:
`/settings/${organization.slug}/integrations/` which should have a
trailing slash in all cases.
If the `provider.key` or `integrationId` segments are missing then a url
of `/settings/${organization.slug}/integrations///` is perfectly fine,
and will take the user to the same page as
`/settings/${organization.slug}/integrations/`. However a url of
`/settings/${organization.slug}/integrations/undefined//` will show an
error on the screen. With the defaults added the error screen should not
be possible anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link should have a trailing
/and should not have "undefined" in any path segment.The way these links are constructed it's possible to have
/undefined/inside the url because of the optional types involved. This change makes the types slightly better in the*MappingLinkfields, and will return empty string instead of"undefined"if needed.The url that these links point to is:
/settings/${organization.slug}/integrations/which should have a trailing slash in all cases.If the
provider.keyorintegrationIdsegments are missing then a url of/settings/${organization.slug}/integrations///is perfectly fine, and will take the user to the same page as/settings/${organization.slug}/integrations/. However a url of/settings/${organization.slug}/integrations/undefined//will show an error on the screen. With the defaults added the error screen should not be possible anymore.