fix AssertionError in snuba 0006_sorting_key_change migration #6203
Conversation
If timestamp already DateTime CODEC(T64, ZSTD(1)) migration fails.
|
I had the same issue as #6186 |
|
Hi, @evanh can u check this? |
|
@wolandspb I've opened #6633 since I think we've had some issues with CI and external contributors in the past so just wanted to make things easy and open one myself. I also verified that I got the same error, and that your fix works. |
|
Thanks a lot, @MeredithAnya! |
Taking over #6203 (from @wolandspb) and creating this PR. Verified that the assertion error below happens locally: ``` File "/Users/meredithaheller/code/snuba/snuba/snuba_migrations/querylog/0006_sorting_key_change.py", line 41, in update_querylog_table assert new_create_table_statement.count(new_timestamp_type) == 0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AssertionError ```
That PR is out of scope for my team, so I don't really have control over when it will get looked at, but I can let other folks know. |
That would be awesome, thanks! |
If timestamp already DateTime CODEC(T64, ZSTD(1)) migration fails.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.