Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to go-git #39

Merged
merged 6 commits into from
Sep 20, 2023
Merged

Switch to go-git #39

merged 6 commits into from
Sep 20, 2023

Conversation

EbonJaeger
Copy link
Member

This switches the git library to go-git, which affords a couple of benefits. Mainly, the API is much nicer to use than libgit2.

Using go-git also makes it easier to build the history for a package, since we no longer use git tags.

I tested this locally by building Caddy, which mixes tarbal and git sources, and gave me problems the last go-around.

This switches the git library to go-git, which affords a couple of benefits. Mainly, the API is much nicer to use than libgit2.

Using go-git also makes it easier to build the history for a package, since we no longer use git tags.

Signed-off-by: Evan Maddock <[email protected]>
@silkeh
Copy link
Member

silkeh commented Sep 20, 2023

Run a gofumpt -l -w . (go install mvdan.cc/gofumpt@latest) to satisfy the linter. Generally LGTM otherwise.

@EbonJaeger EbonJaeger force-pushed the switch-to-go-git-again branch from cad892d to 5fe864c Compare September 20, 2023 15:13
Copy link
Member

@silkeh silkeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants