Use Git directly instead of any bindings #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EbonJaeger
force-pushed
the
fix-go-git
branch
from
60a14f6
to
b9c406f
Compare
This tries to make go-git work with getting a shallow clone of a specific tag or commit. In its current state, getting a commit might work. Getting a tag, however, does not. Trying to resolve a tag ends up with a hash that doesn't exist when you try to fetch it. I don't know if I'm doing something wrong, go-git is doing something wrong, or a combination of both. Signed-off-by: Evan Maddock <[email protected]>
EbonJaeger
force-pushed
the
fix-go-git
branch
2 times, most recently
from
44d5a70
to
745a18f
Compare
go-git just isn't working for our needs, and we want to drop git2go and have shallow cloning, so just calling out to Git directly is the best way to go. Signed-off-by: Evan Maddock <[email protected]>
EbonJaeger
force-pushed
the
fix-go-git
branch
from
745a18f
to
4cd1932
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the use of go-git in favor of just calling Git directly for fetching Git sources. Repos will be shallow cloned initially, and hard resetting to update the local copy to a different revision.
Tested by building a package using a Git tag and a Git commit, and updating the local repo with a different Git tag and Git commit.