Skip to content

Commit

Permalink
Bump monerod version to v0.18.3.4
Browse files Browse the repository at this point in the history
  • Loading branch information
@colder-is-better
colder-is-better committed Nov 15, 2024
1 parent 9aaafeb commit 7882377
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion monero/docker-compose.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ services:
restart: unless-stopped

Check warning on line 43 in monero/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Invalid restart policy 

The restart policy of the container "monerod" should be set to "on-failure".
stop_grace_period: 15m
command: "${APP_MONERO_COMMAND}"
image: ghcr.io/sethforprivacy/simple-monerod:v0.18.3.3@sha256:4e07ca4119cd34d61684c44151296535cb9ba674e081d0a622432be4ac51c2c9
image: ghcr.io/sethforprivacy/simple-monerod:v0.18.3.4@sha256:26535f28aba4e8404a8a9a362b27beadfa48e25e23b73c20886cdbe342013690
ports:

Check notice on line 47 in monero/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

External port mapping "${APP_MONERO_P2P_PORT}:${APP_MONERO_P2P_PORT}" 

Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).

Check notice on line 47 in monero/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

External port mapping "${APP_MONERO_RPC_PORT}:${APP_MONERO_RPC_PORT}" 

Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
- "${APP_MONERO_P2P_PORT}:${APP_MONERO_P2P_PORT}"
- "${APP_MONERO_RPC_PORT}:${APP_MONERO_RPC_PORT}"
Expand Down
4 changes: 2 additions & 2 deletions monero/umbrel-app.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ manifestVersion: 1.1
id: monero
category: finance
name: Monero Node
version: "0.18.3.3"
version: "0.18.3.4"
tagline: Run a monero node
description: >-
Run your monero node and independently store and validate every single Monero transaction with it.
Expand All @@ -22,4 +22,4 @@ gallery:
- 3.jpg
path: ""
defaultPassword: ""
releaseNotes: ""
releaseNotes: ""

0 comments on commit 7882377

Please sign in to comment.