Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update electrs to v0.10.7 #1837

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Update electrs to v0.10.7 #1837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions electrs/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: "3.7"

Check notice on line 1 in electrs/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Potentially using unsafe user in service "app" 

The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

Check notice on line 1 in electrs/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Potentially using unsafe user in service "electrs" 

The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

services:
app_proxy:
Expand All @@ -7,7 +7,7 @@
APP_PORT: 3006

app:
image: getumbrel/umbrel-electrs:v1.0.2@sha256:3dae686b22b1fdfd72ff058d022045f96cc5116e76f82f435d58f1cfe8f46418
image: getumbrel/umbrel-electrs:v1.0.4@sha256:fa2fd04f4c7515aad84f21640f5feab1417bc18e20bc65cda7ed97e59b8458db
depends_on:
- electrs
restart: on-failure
Expand All @@ -24,8 +24,8 @@
ipv4_address: $APP_ELECTRS_IP

electrs:
image: getumbrel/electrs:v0.10.6@sha256:e8e23c02d82eccad3d0a82cd00270e799b6484dad482fe8cae8f8964efb1e8a1
image: getumbrel/electrs:v0.10.7@sha256:f8831afff4014528a3fdb1e3ccd606bd4c9474ddc25a4b318c5ba6ba50e5b734
restart: always

Check warning on line 28 in electrs/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Invalid restart policy 

The restart policy of the container "electrs" should be set to "on-failure".
environment:
ELECTRS_LOG_FILTERS: "INFO"
ELECTRS_NETWORK: "${APP_BITCOIN_NETWORK_ELECTRS}"
Expand All @@ -37,7 +37,7 @@
volumes:
- "${APP_BITCOIN_DATA_DIR}:/data/.bitcoin:ro"
- "${APP_DATA_DIR}/data/electrs:/data"
ports:

Check notice on line 40 in electrs/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

External port mapping "${APP_ELECTRS_NODE_PORT}:${APP_ELECTRS_NODE_PORT}" 

Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
- "${APP_ELECTRS_NODE_PORT}:${APP_ELECTRS_NODE_PORT}"
networks:
default:
Expand All @@ -47,7 +47,7 @@
image: getumbrel/tor:0.4.7.8@sha256:2ace83f22501f58857fa9b403009f595137fa2e7986c4fda79d82a8119072b6a
user: "1000:1000"
restart: on-failure
volumes:

Check notice on line 50 in electrs/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Mounted file/directory "/electrs/torrc" doesn't exist 

The volume "${APP_DATA_DIR}/torrc:/etc/tor/torrc:ro" tries to mount the file/directory "/electrs/torrc", but it is not present. This can lead to permission errors!
- ${APP_DATA_DIR}/torrc:/etc/tor/torrc:ro
- ${TOR_DATA_DIR}:/data
environment:
Expand Down
11 changes: 3 additions & 8 deletions electrs/umbrel-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ manifestVersion: 1.1
id: electrs
category: bitcoin
name: Electrs
version: "0.10.6"
version: "0.10.7"
tagline: A simple and efficient Electrum Server
description: >
Run your personal Electrum server and connect your Electrum-compatible wallet,
Expand Down Expand Up @@ -30,14 +30,9 @@ gallery:
path: ""
defaultPassword: ""
releaseNotes: >
Highlights:
- Added support for latest version of bitcoind
- Improved stability and error handling for mempool sync and fee estimation processes
- Enhanced efficiency by optimizing database memory usage
- Deprecated unused config option timestampindex
- Updated software dependencies for better compatibility and performance
This release adds support for testnet4 and prevents mempool syncing until bitcoind's mempool is fully loaded.


Full release notes are available at https://github.com/romanz/electrs/blob/master/RELEASE-NOTES.md#0106-sep-29-2024
Full release notes are available at https://github.com/romanz/electrs/blob/master/RELEASE-NOTES.md#0107-nov-05-2024
submitter: Umbrel
submission: https://github.com/getumbrel/umbrel/pull/242