Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zoraxy v3.1.6 #2165

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Update zoraxy v3.1.6 #2165

merged 2 commits into from
Feb 10, 2025

Conversation

al-lac
Copy link
Contributor

@al-lac al-lac commented Feb 6, 2025

🤖 This is an automated summary of installation tests for zoraxy:

  • ✅ App successfully installed in umbrel-dev instance
  • ✅ App successfully listed in umbrel.yaml
  • ✅ App UI successfully returns a 200 status code
  • 📸 Screenshot of the app:
    App Screenshot

This PR must still be reviewed and tested before merging.

Fixes #2170

Copy link

github-actions bot commented Feb 6, 2025

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ zoraxy/docker-compose.yml Mounted file/directory "/zoraxy/data/config/" doesn't exist:
The volume "${APP_DATA_DIR}/data/config/:/opt/zoraxy/config" tries to mount the file/directory "/zoraxy/data/config/", but it is not present. This can lead to permission errors!
ℹ️ zoraxy/docker-compose.yml External port mapping "41080:80":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
ℹ️ zoraxy/docker-compose.yml External port mapping "41443:443":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
ℹ️ zoraxy/docker-compose.yml Potentially using unsafe user in service "server":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@al-lac al-lac mentioned this pull request Feb 8, 2025
@nmfretz
Copy link
Contributor

nmfretz commented Feb 10, 2025

Reviewed and tested (app update)

@nmfretz nmfretz merged commit 6181bf6 into getumbrel:master Feb 10, 2025
1 check passed
@al-lac al-lac deleted the update-zoraxy-v3.1.6 branch February 10, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to update Zoraxy app
2 participants