This repository has been archived by the owner on Jun 23, 2023. It is now read-only.
Add the possibility to rename #291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louneskmt
previously approved these changes
Jan 21, 2021
AaronDewes
reviewed
Jan 22, 2021
src/views/Settings.vue
Outdated
| } | ||
|
|
||
| this.$bvToast.toast( | ||
| `You've successfully changed your Name`, |
There was a problem hiding this comment.
Suggested change
| `You've successfully changed your Name`, | |
| `You've successfully changed your name`, |
Shouldn't this be lowercase?
AaronDewes
reviewed
Jan 22, 2021
src/views/Settings.vue
Outdated
| size="lg" | ||
| :disabled="isChangingName || newName.length === 0" | ||
| @click="changeName" | ||
| >{{ isChangingName ? 'Changing Name...' : 'Change name'}}</b-button> |
src/views/Settings.vue
Outdated
| @@ -380,6 +439,56 @@ export default { | |||
| getReadableTime(timestamp) { | |||
| return moment(timestamp).format("MMM D, h:mm:ss a"); | |||
| }, | |||
| async changeName() { | |||
| if (this.newName.length === 0) { | |||
| return this.$bvToast.toast("Trying to set an empty name...", { | |||
There was a problem hiding this comment.
I would replace this message with "You name must not be empty" or something like that
louneskmt
reviewed
Jan 22, 2021
|
@bguillaumat Can you rebase this PR? |
Little fixes Fix typo error Co-authored-by: Lounès Ksouri <[email protected]>
bguillaumat
force-pushed
the
add-change-name
branch
from
3367b2a to
5091206
Compare
Done |
|
Seems like there still is a conflict... Also for the other branch. Make sure to rebase this on Umbrel's master branch, not the master branch of your fork. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to getumbrel/umbrel-manager#74