This repository has been archived by the owner on May 10, 2023. It is now read-only.
(Fix) Remove redundant 'gsed' dependency check #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gsed
isn't present on Linux and causescheck_dependencies
to fail. This PR removes the check which should be fine for Linux machines sincesed
is pretty standard and should still be ok for MacOS because thegsed
dependency is already checked a few lines above this change.(If missing
sed
becomes an issue later on for Linux users, we can also create ased
check-and-install like you guys did forgsed
and MacOS)Helps to address Issue #4, I was able to successfully complete
$ umbrel-dev init
after this change on an Ubuntu 18.04 system