Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

(Fix) Remove redundant 'gsed' dependency check #8

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

vindard
Copy link
Contributor

@vindard vindard commented Aug 6, 2020

Description

gsed isn't present on Linux and causes check_dependencies to fail. This PR removes the check which should be fine for Linux machines since sed is pretty standard and should still be ok for MacOS because the gsed dependency is already checked a few lines above this change.

(If missing sed becomes an issue later on for Linux users, we can also create a sed check-and-install like you guys did for gsed and MacOS)

Helps to address Issue #4, I was able to successfully complete $ umbrel-dev init after this change on an Ubuntu 18.04 system

'gsed' isn't present on Linux and causes 'check_dependencies' to
fail. Removing here should be fine since 'sed' usually comes with
Linux systems and 'gnused' should get aliased successfully to 'sed'
higher up in the script. For MacOS, there is already a check above
this for 'gsed'
@vindard
Copy link
Contributor Author

vindard commented Aug 6, 2020

Not sure if this helps but I also got stuck with a bad (old) version of vagrant from apt repository that halted my $ umbrel-dev init run with the error* below. I had to update my version to the latest manually, but this script should handle this install/update for Linux machines:

#!/bin/bash

if [[ "$(uname)" == "Linux" ]]; then
  if ! command -v jq >/dev/null 2>&1; then
    sudo apt update && sudo apt install jq -y
  fi
  vagrant_deb=$(echo "https://releases.hashicorp.com/vagrant/$(curl -s https://checkpoint-api.hashicorp.com/v1/check/vagrant | jq -r -M '.current_version')/vagrant_$(curl -s https://checkpoint-api.hashicorp.com/v1/check/vagrant | jq -r -M '.current_version')_$(uname -m).deb")
  wget -c $vagrant_deb
  sudo dpkg -i $vagrant_deb
  rm $(basename $vagrant_deb)
fi


error* - conflicting dependencies fog-core (~> 1.43.0) and fog-core (= 1.45.0)

@vindard vindard mentioned this pull request Aug 6, 2020
@mayankchhabra
Copy link
Member

Hey, thanks for your PR, @vindard! LGTM.

Luke's away for a couple of days and since I'm not very familiar with the working of umbrel-dev, I'll wait for him to be back so he can chime in.

@vindard
Copy link
Contributor Author

vindard commented Aug 6, 2020

Sure no probs, I bet it'd be useful as documentation here if anyone runs across the same thing and comes poking around the issue tracker either way

@lukechilds lukechilds self-assigned this Aug 12, 2020
@lukechilds
Copy link
Member

Thanks for this @vindard!

Apologies for the slow response, looks great.

@lukechilds lukechilds merged commit afb86df into getumbrel:master Aug 20, 2020
@jgmontoya jgmontoya mentioned this pull request Sep 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants