This repository has been archived by the owner on Jun 23, 2023. It is now read-only.
Add user settings API + Logic #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EddWills95
previously approved these changes
Nov 2, 2020
lukechilds
suggested changes
Nov 6, 2020
There was a problem hiding this comment.
Thanks for working on this!
Really sorry for the delay in review.
I think this can be simplified quite a bit by using a nested object in user.json for settings instead of creating a new file. See feedback for detailed explanation.
Please let me know if I've overlooked something and there's a reason you think it's better to do it this way.
lukechilds
suggested changes
Nov 6, 2020
lukechilds
suggested changes
Nov 7, 2020
louneskmt
force-pushed
the
settings-file
branch
from
bc238db to
d78d765
Compare
|
This PR seems to be blocking couple of others, is there anything else that needs to be done? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the routes and the logic to allow custom user settings.
New routes:
/v1/account/settings: get existing user settings/v1/account/settings(request body:settingandvalue): update one setting to a new value, add it if neededRelated PR: