Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removed Object#blank? monkey patch #83

Draft
wants to merge 1 commit into
base: 01-06-chore_replaced_rubocop_w__standardrb
Choose a base branch
from

Conversation

jylamont
Copy link
Contributor

@jylamont jylamont commented Jan 7, 2025

Vero gem was unnecessarily monkey patching blank? into Object. This PR removes the monkey patch and replaces blank? with nil? and empty?.

Copy link
Contributor Author

jylamont commented Jan 7, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jylamont jylamont force-pushed the 01-06-chore_replaced_rubocop_w__standardrb branch from f5172ed to ebf5049 Compare January 7, 2025 16:29
@jylamont jylamont force-pushed the 01-06-chore_removed_object_blank_monkey_patch branch from d537a92 to 03f45b7 Compare January 7, 2025 16:29
@jylamont jylamont force-pushed the 01-06-chore_replaced_rubocop_w__standardrb branch from ebf5049 to 72d2e5a Compare January 7, 2025 16:40
@jylamont jylamont force-pushed the 01-06-chore_removed_object_blank_monkey_patch branch from 03f45b7 to 7434687 Compare January 7, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant