Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdk 2230 expose share v2 api #299

Merged
merged 143 commits into from
Jan 4, 2024
Merged

Conversation

mehmet-yoti
Copy link
Contributor

Share V2 branches were added to "Sdk 2230 expose share v2 api" and now will merge to development

mehmet-yoti and others added 30 commits April 6, 2023 08:48
Co-authored-by: Klaidas Urbanavicius <[email protected]>
Co-authored-by: Klaidas Urbanavicius <[email protected]>
Co-authored-by: Klaidas Urbanavicius <[email protected]>
Co-authored-by: Klaidas Urbanavicius <[email protected]>
…yoti-go-sdk into SDK-2240-sharev2-go-create-session
Co-authored-by: Klaidas Urbanavicius <[email protected]>
…yoti-go-sdk into SDK-2240-sharev2-go-create-session
mehmet-yoti and others added 22 commits November 23, 2023 14:46
Co-authored-by: Klaidas Urbanavicius <[email protected]>
Co-authored-by: Klaidas Urbanavicius <[email protected]>
Co-authored-by: Klaidas Urbanavicius <[email protected]>
Co-authored-by: Klaidas Urbanavicius <[email protected]>
Co-authored-by: Klaidas Urbanavicius <[email protected]>
Co-authored-by: Klaidas Urbanavicius <[email protected]>
Co-authored-by: Klaidas Urbanavicius <[email protected]>
Co-authored-by: Klaidas Urbanavicius <[email protected]>
Co-authored-by: Klaidas Urbanavicius <[email protected]>
Co-authored-by: Klaidas Urbanavicius <[email protected]>
Co-authored-by: Klaidas Urbanavicius <[email protected]>
Co-authored-by: Klaidas Urbanavicius <[email protected]>
Co-authored-by: Klaidas Urbanavicius <[email protected]>
README.md Outdated Show resolved Hide resolved
@klaidas
Copy link
Collaborator

klaidas commented Dec 20, 2023

i just matched up the expected commits, didn't actually look at the code changes (other than that readme that was at the top), seems fine, kinda hard to review otherwise

mehmet-yoti and others added 2 commits January 4, 2024 10:21
Copy link

@irotech irotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG from the API POV

  • please squash commits before merging

@mehmet-yoti mehmet-yoti merged commit 8607a79 into development Jan 4, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants