WIP: Voltage Monitor improvements on Nucleo #112
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading VREFINT allows us to measure the voltage at VDDA instead of just assuming that it is 3.3V.
rnestler
commented
Oct 5, 2021
| /// Read the VREFINT value | ||
| pub fn read_vref_raw(&mut self) -> Option<u16> { | ||
| VRef.enable(&mut self.adc); | ||
| let val = self.adc.read(&mut VRef).ok(); |
There was a problem hiding this comment.
We should wait around 3ms between the enable and the read. But not much longer to avoid power usage. Should we do the API asynchronously?
There was a problem hiding this comment.
Yes, I'd split enabling and reading into separate methods.
Does VRef draw significant power as well? If yes, we should probably have a dedicated task that reads the data after 3ms and turns off VRef. If not, we can collect the measurement together with the other sensor data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.