Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for comitting candidate intersections #6759

Closed
Vecvec opened this issue Dec 16, 2024 · 2 comments · Fixed by #7047
Closed

Allow for comitting candidate intersections #6759

Vecvec opened this issue Dec 16, 2024 · 2 comments · Fixed by #7047
Assignees
@kvark
Labels
area: api Issues related to API surface area: naga front-end feature: raytracing Issues with the Ray Tracing Native Feature lang: WGSL WebGPU Shading Language naga Shader Translator type: enhancement New feature or request

Comments

@Vecvec
Copy link
Contributor

Vecvec commented Dec 16, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently Ray Queries support getting candidate intersections. However unlike spirv, naga does not have a way to commit these candidate intersection.

Describe the solution you'd like
A way to commit the candidate intersections like OpRayQueryConfirmIntersectionKHR

Describe alternatives you've considered
Just let the user use and compare it with the committed intersections - this is probably slower and uses more memory.

Additional context
N/A
@cwfitzgerald cwfitzgerald added type: enhancement New feature or request area: api Issues related to API surface naga Shader Translator area: naga front-end lang: WGSL WebGPU Shading Language feature: raytracing Issues with the Ray Tracing Native Feature labels Dec 16, 2024
@Vecvec Vecvec mentioned this issue Dec 16, 2024
Open
26 tasks
@Jaisiero
Copy link

Jaisiero commented Jan 6, 2025

Awesome! I am looking forward for this implementation. I am 100% confident this is necessary for user custom intersections (aka procedural or AABB) in the future.

@kvark kvark self-assigned this Feb 1, 2025
@kvark kvark changed the title Allow for comitting candidate intersecctions Allow for comitting candidate intersections Feb 1, 2025
@kvark kvark mentioned this issue Feb 1, 2025
Merged
6 tasks
@kvark
Copy link
Member

kvark commented Feb 1, 2025

Realized this was missing and proceeded with #7047 to fill the gap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvark kvark

Labels
area: api Issues related to API surface area: naga front-end feature: raytracing Issues with the Ray Tracing Native Feature lang: WGSL WebGPU Shading Language naga Shader Translator type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement ray query candidate intersection generation and confirmation kvark/wgpu
4 participants
@kvark @Jaisiero @cwfitzgerald @Vecvec