Implement ray query candidate intersection generation and confirmation #7047
+250
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
force-pushed
the
rt-confirm
branch
3 times, most recently
from
9d50d75 to
8cbea73
Compare
kvark
force-pushed
the
rt-confirm
branch
4 times, most recently
from
970b0bf to
16c902b
Compare
Vecvec
approved these changes
Feb 2, 2025
| @@ -2,23 +2,23 @@ | |||
|
|
|||
| 🧪Experimental🧪 | |||
|
|
|||
| `wgpu` supports an experimental version of ray tracing which is subject to change. The extensions allow for acceleration structures to be created and built (with | |||
There was a problem hiding this comment.
It might not be helpful to have these formatting changes.
There was a problem hiding this comment.
Looks harmless though? Also, unintentional - my editor made them automatically.
There was a problem hiding this comment.
Yeah, but it made it slower to figure out what had changed. Personally I don't think this really needs to be fixed as it would be difficult but it might be worth turning that feature off in your editor if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #6759
Description
Implements missing functionality for working with candidate intersections.
These functions are only functional in SPIR-V and HLSL.
Metal doesn't appear to expose this in the "old" API - we need to hook up their newer ray query objects.
Testing
Just shader validation. The function signatures are fairly straightforward.
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.