Fix building wgpu with --no-default-feautures on web (wasm32-unknown-unknown)
#6946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
the
PR: needs back-porting
Wumpf
changed the title
wgpu --no-default-feautures on web (wasm32-unknown-unknown) buildswgpu with --no-default-feautures on web (wasm32-unknown-unknown)
Wumpf
force-pushed
the
fix-no-default-features-build
branch
from
c05d6ad to
b2550a4
Compare
cwfitzgerald
pushed a commit
that referenced
this pull request
Jan 23, 2025
…nown-unknown`) (#6946) * Fix wasm build without features * silence unused warnings if wgc & webgpu are disabled * add no-features check for web ci * add changelog entry # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
When building with
--no-default-featureson web, we have neitherwgpu_corenorwebgpumeta features enabled. This causes the match expressions not to compile.A nicer way to solve this would be an
emptybackend as previously proposed here where @daxpedda made a good case for it.I was pushing against it back then because of yet-another-place-naming-all-interfaces, but I think I changed my mind on this and this would actually be really useful to have - we could automatically enable the empty-backend when neither webgpu or wgc are enabled and allow it to be added via feature & created explicitly etc.
.... but more on that in another PR. For now I wanted this one to be usable in a patch release!
Testing
Added previously failing check to ci
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.