[naga] Require hashbrown's serde feature as a dev-dependency. #7039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
added
area: tests
Add `hashbrown` with the `"serde"` feature as a development dependency for Naga. Regardless of whether Naga's `deserialize` feature is enabled, the snapshot tests need to deserialize parameters saved in files as RON text. It would also suffice to use `std::collections::HashSet` in the snapshot tests, although we would need to build a `naga::FashHashSet` from the std `HashSet` at one point. Adding the dev-dependency seems slightly simpler. Fixes gfx-rs#7038.
jimblandy
force-pushed
the
naga-snapshot-hashbrown-serde
branch
from
54781b9 to
d04df38
Compare
cwfitzgerald
approved these changes
Jan 30, 2025
| @@ -117,3 +117,4 @@ ron = "0.8.0" | |||
| rspirv = { version = "0.11", git = "https://github.com/gfx-rs/rspirv", rev = "b969f175d5663258b4891e44b76c1544da9661ab" } | |||
| serde = { workspace = true, features = ["default", "derive"] } | |||
| spirv = { version = "0.3", features = ["deserialize"] } | |||
| hashbrown = { workspace = true, features = ["serde"] } | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
hashbrownwith the"serde"feature as a development dependency for Naga. Regardless of whether Naga'sdeserializefeature is enabled, the snapshot tests need to deserialize parameters saved in files as RON text.It would also suffice to use
std::collections::HashSetin the snapshot tests, although we would need to build anaga::FashHashSetfrom the stdHashSetat one point. Adding the dev-dependency seems slightly simpler.Fixes #7038.