Bug fixed file::isReadable() which was broken!

ggarra13 · Feb 25, 2024 · 2ed8949 · 2ed8949
1 parent 70e25ac
commit 2ed8949
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/mrv2/docs/HISTORY.md b/mrv2/docs/HISTORY.md
@@ -26,6 +26,9 @@ v1.0.7
 - Removed view sources from html docs to save space on disk.
 - Cleaned up docs directory before building docs.
 - Sped up creation of docs in build system.
+- Updated Python API with FFmpeg and Background changes.
+- Fixed reading permissions on files as they were broken!  I did not notice
+  as I was using an NTFS drive which sets umask 0022 by default.
 
 
 v1.0.6

diff --git a/mrv2/lib/mrvCore/mrvFile.cpp b/mrv2/lib/mrvCore/mrvFile.cpp
@@ -128,8 +128,8 @@ namespace mrv
             if (!fs::exists(p, ec) || fileName.empty())
                 return false;
             auto perms = fs::status(p, ec).permissions();
-            if ((perms & fs::perms::owner_read) != fs::perms::none &&
-                (perms & fs::perms::group_read) != fs::perms::none &&
+            if ((perms & fs::perms::owner_read) != fs::perms::none ||
+                (perms & fs::perms::group_read) != fs::perms::none ||
                 (perms & fs::perms::others_read) != fs::perms::none)
             {
                 return true;