Skip to content

Commit

Permalink
CUDA: revert part of the RDNA1 optimizations (#8309)
Browse files Browse the repository at this point in the history
The change on the launch_bounds was causing a small performance drop in perplexity of 25 t/s
  • Loading branch information
daniandtheweb authored Jul 5, 2024
1 parent d12f781 commit 0a42380
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ggml/src/ggml-cuda/mmq.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -2263,9 +2263,9 @@ static __device__ void mul_mat_q_process_tile(

template <ggml_type type, int mmq_x, int nwarps, bool need_check>
#if defined(GGML_USE_HIPBLAS) && defined(__HIP_PLATFORM_AMD__)
#if defined(RDNA3) || defined(RDNA2) || defined(RDNA1)
#if defined(RDNA3) || defined(RDNA2)
__launch_bounds__(WARP_SIZE*nwarps, 2)
#endif // defined(RDNA3) || defined(RDNA2) || defined(RDNA1)
#endif // defined(RDNA3) || defined(RDNA2)
#else
#if __CUDA_ARCH__ >= CC_VOLTA
__launch_bounds__(WARP_SIZE*nwarps, 1)
Expand Down

0 comments on commit 0a42380

Please sign in to comment.