Skip to content

Commit

Permalink
control-vectors : minor code style updates
Browse files Browse the repository at this point in the history
  • Loading branch information
ggerganov committed Mar 14, 2024
1 parent 42abb46 commit 0a9bc30
Show file tree
Hide file tree
Showing 4 changed files with 113 additions and 99 deletions.
145 changes: 71 additions & 74 deletions common/common.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -573,30 +573,29 @@ bool gpt_params_parse_ex(int argc, char ** argv, gpt_params & params) {
invalid_param = true;
break;
}
params.control_vectors.push_back(std::make_tuple(argv[i], 1.0f));
params.control_vectors.push_back({ 1.0f, argv[i], });
} else if (arg == "--control-vector-scaled") {
if (++i >= argc) {
invalid_param = true;
break;
}
const char * control_vector = argv[i];
const char * fname = argv[i];
if (++i >= argc) {
invalid_param = true;
break;
}
params.control_vectors.push_back(std::make_tuple(control_vector, std::stof(argv[i])));
params.control_vectors.push_back({ std::stof(argv[i]), fname, });
} else if (arg == "--control-vector-layer-range") {
if (++i >= argc) {
invalid_param = true;
break;
}
int32_t start = std::stoi(argv[i]);
params.control_vector_layer_start = std::stoi(argv[i]);
if (++i >= argc) {
invalid_param = true;
break;
}
int32_t end = std::stoi(argv[i]);
params.control_vector_layer_range = std::make_tuple(start, end);
params.control_vector_layer_end = std::stoi(argv[i]);
} else if (arg == "--mmproj") {
if (++i >= argc) {
invalid_param = true;
Expand Down Expand Up @@ -1396,27 +1395,22 @@ std::tuple<struct llama_model *, struct llama_context *> llama_init_from_gpt_par
}

if (!params.control_vectors.empty()) {
int32_t layer_start, layer_end;
std::tie(layer_start, layer_end) = params.control_vector_layer_range;
if (params.control_vector_layer_start <= 0) params.control_vector_layer_start = 1;
if (params.control_vector_layer_end <= 0) params.control_vector_layer_end = llama_n_layer(model);

if (layer_start == 0) layer_start = 1;
if (layer_end == 0) layer_end = 31;

std::vector<float> control_vector;
int n_embd;
std::tie(control_vector, n_embd) = llama_control_vector_load(params.control_vectors);
if (n_embd == -1) {
const auto cvec = llama_control_vector_load(params.control_vectors);
if (cvec.n_embd == -1) {
llama_free(lctx);
llama_free_model(model);
return std::make_tuple(nullptr, nullptr);
}

int err = llama_control_vector_apply(lctx,
control_vector.data(),
control_vector.size(),
n_embd,
layer_start,
layer_end);
cvec.data.data(),
cvec.data.size(),
cvec.n_embd,
params.control_vector_layer_start,
params.control_vector_layer_end);
if (err) {
llama_free(lctx);
llama_free_model(model);
Expand Down Expand Up @@ -1959,11 +1953,14 @@ float llama_embd_similarity_cos(const float * embd1, const float * embd2, int n)
// Control vector utils
//

static std::tuple<std::vector<float>, int> llama_control_vector_load_one(const std::string & path, float strength) {
int n_tensors;
static llama_control_vector_data llama_control_vector_load_one(const llama_control_vector_load_info & load_info) {
int32_t n_tensors;

size_t n_bytes = 0;

uint32_t max_direction_layer = 0;
int n_embd = -1;

llama_control_vector_data result = { -1, {} };

// calculate size of ctx needed for tensors, ensure tensors are f32, and find max layer
{
Expand All @@ -1977,11 +1974,11 @@ static std::tuple<std::vector<float>, int> llama_control_vector_load_one(const s
/* .no_alloc = */ true,
/* .ctx = */ &meta_ctx,
};
struct gguf_context * meta_ctx_gguf = gguf_init_from_file(path.c_str(), meta_gguf_params);
struct gguf_context * meta_ctx_gguf = gguf_init_from_file(load_info.fname.c_str(), meta_gguf_params);
if (!meta_ctx_gguf) {
fprintf(stderr, "%s: failed to load control vector from %s\n", __func__, path.c_str());
fprintf(stderr, "%s: failed to load control vector from %s\n", __func__, load_info.fname.c_str());
ggml_free(meta_ctx);
return std::make_tuple(std::vector<float>(), -1);
return result;
}

n_tensors = gguf_get_n_tensors(meta_ctx_gguf);
Expand All @@ -1994,36 +1991,36 @@ static std::tuple<std::vector<float>, int> llama_control_vector_load_one(const s
try {
uint32_t layer = std::stoi(name.substr(dotpos + 1));
if (layer == 0) {
fprintf(stderr, "%s: direction tensor invalid in %s\n", __func__, path.c_str());
fprintf(stderr, "%s: direction tensor invalid in %s\n", __func__, load_info.fname.c_str());
ggml_free(meta_ctx);
gguf_free(meta_ctx_gguf);
return std::make_tuple(std::vector<float>(), -1);
return result;
}
if (layer > max_direction_layer) {
max_direction_layer = layer;
}
} catch (...) {
fprintf(stderr, "%s: direction tensor invalid in %s\n", __func__, path.c_str());
fprintf(stderr, "%s: direction tensor invalid in %s\n", __func__, load_info.fname.c_str());
ggml_free(meta_ctx);
gguf_free(meta_ctx_gguf);
return std::make_tuple(std::vector<float>(), -1);
return result;
}
}

struct ggml_tensor * tensor_meta = ggml_get_tensor(meta_ctx, name.c_str());
if (tensor_meta->type != GGML_TYPE_F32 || ggml_n_dims(tensor_meta) != 1) {
fprintf(stderr, "%s: direction tensor invalid in %s\n", __func__, path.c_str());
fprintf(stderr, "%s: direction tensor invalid in %s\n", __func__, load_info.fname.c_str());
ggml_free(meta_ctx);
gguf_free(meta_ctx_gguf);
return std::make_tuple(std::vector<float>(), -1);
return result;
}
if (n_embd == -1) {
n_embd = ggml_nelements(tensor_meta);
} else if (ggml_nelements(tensor_meta) != n_embd) {
fprintf(stderr, "%s: direction tensor sizes mismatched in %s\n", __func__, path.c_str());
if (result.n_embd == -1) {
result.n_embd = ggml_nelements(tensor_meta);
} else if (ggml_nelements(tensor_meta) != result.n_embd) {
fprintf(stderr, "%s: direction tensor sizes mismatched in %s\n", __func__, load_info.fname.c_str());
ggml_free(meta_ctx);
gguf_free(meta_ctx_gguf);
return std::make_tuple(std::vector<float>(), -1);
return result;
}
n_bytes += ggml_nbytes(tensor_meta);
}
Expand All @@ -2032,8 +2029,8 @@ static std::tuple<std::vector<float>, int> llama_control_vector_load_one(const s
}

if (n_tensors == 0) {
fprintf(stderr, "%s: no direction tensors found in %s\n", __func__, path.c_str());
return std::make_tuple(std::vector<float>(), -1);
fprintf(stderr, "%s: no direction tensors found in %s\n", __func__, load_info.fname.c_str());
return result;
}

// load and scale tensors into final control vector context
Expand All @@ -2048,63 +2045,63 @@ static std::tuple<std::vector<float>, int> llama_control_vector_load_one(const s
/*.no_alloc = */ false,
/*.ctx = */ &ctx,
};
struct gguf_context * ctx_gguf = gguf_init_from_file(path.c_str(), params);
struct gguf_context * ctx_gguf = gguf_init_from_file(load_info.fname.c_str(), params);
if (!ctx_gguf) {
fprintf(stderr, "%s: failed to load control vector from %s\n", __func__, path.c_str());
fprintf(stderr, "%s: failed to load control vector from %s\n", __func__, load_info.fname.c_str());
ggml_free(ctx);
return std::make_tuple(std::vector<float>(), -1);
return result;
}

std::vector<float> vector;
for (uint32_t i = 1; i < max_direction_layer; i++) {
std::string name = "direction." + std::to_string(i);
ggml_tensor * tensor = ggml_get_tensor(ctx, name.c_str());
// do not store data for layer 0 (it's not used)
result.data.resize(result.n_embd * max_direction_layer);

for (uint32_t il = 1; il <= max_direction_layer; il++) {
const std::string name = "direction." + std::to_string(il);
const ggml_tensor * tensor = ggml_get_tensor(ctx, name.c_str());

float * dst = result.data.data() + result.n_embd * (il - 1);

if (tensor) {
const float * data = (const float *) tensor->data;
for (int i = 0; i < n_embd; i++) {
vector.push_back(data[i] * strength);
const float * src = (const float *) tensor->data;
for (int j = 0; j < result.n_embd; j++) {
dst[j] = src[j] * load_info.strength;
}
} else {
vector.insert(vector.end(), n_embd, 0.); // as a filler
for (int j = 0; j < result.n_embd; j++) {
dst[j] = 0.0f;
}
}
}

return std::make_tuple(vector, n_embd);
return result;
}

std::tuple<std::vector<float>, int> llama_control_vector_load(const std::vector<std::tuple<std::string, float>> & vectors) {
std::vector<float> vector;
int n_embd = -1;
llama_control_vector_data llama_control_vector_load(const std::vector<llama_control_vector_load_info> & load_infos) {
llama_control_vector_data result = { -1, {} };

for (const auto& pair : vectors) {
std::string path;
float strength;
std::tie(path, strength) = pair;
for (const auto & info : load_infos) {
auto cur = llama_control_vector_load_one(info);

std::vector<float> v;
int v_n_embd;
std::tie(v, v_n_embd) = llama_control_vector_load_one(path, strength);

if (v_n_embd == -1) {
return std::make_tuple(std::vector<float>(), -1);
if (cur.n_embd == -1) {
return result;
}
if (n_embd != -1 && (n_embd != v_n_embd || v.size() != vector.size())) {
fprintf(stderr, "%s: control vector in %s does not match previous vector dimensions\n", __func__, path.c_str());
return std::make_tuple(std::vector<float>(), -1);
if (result.n_embd != -1 && (result.n_embd != cur.n_embd || result.data.size() != cur.data.size())) {
fprintf(stderr, "%s: control vector in %s does not match previous vector dimensions\n", __func__, info.fname.c_str());
return result;
}

if (n_embd == -1) {
vector = std::move(v);
n_embd = v_n_embd;
if (result.n_embd == -1) {
result = std::move(cur);
} else {
for (size_t i = 0; i < vector.size(); i++) {
vector[i] += v[i];
for (size_t i = 0; i < cur.data.size(); i++) {
result.data[i] += cur.data[i];
}
}
}

if (n_embd == -1) {
if (result.n_embd == -1) {
fprintf(stderr, "%s: no vectors passed\n", __func__);
}
return std::make_tuple(vector, n_embd);

return result;
}
32 changes: 24 additions & 8 deletions common/common.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,13 @@ extern char const *LLAMA_COMMIT;
extern char const *LLAMA_COMPILER;
extern char const *LLAMA_BUILD_TARGET;

struct llama_control_vector_load_info;

int32_t get_num_physical_cores();

//
// CLI argument parsing
//
int32_t get_num_physical_cores();

struct gpt_params {
uint32_t seed = LLAMA_DEFAULT_SEED; // RNG seed
Expand Down Expand Up @@ -103,8 +106,10 @@ struct gpt_params {
std::vector<std::tuple<std::string, float>> lora_adapter; // lora adapter path with user defined scale
std::string lora_base = ""; // base model path for the lora adapter

std::vector<std::tuple<std::string, float>> control_vectors; // control vector with user defined scale
std::tuple<int32_t, int32_t> control_vector_layer_range; // layer range for control vector
std::vector<llama_control_vector_load_info> control_vectors; // control vector with user defined scale

int32_t control_vector_layer_start = -1; // layer range for control vector
int32_t control_vector_layer_end = -1; // layer range for control vector

int ppl_stride = 0; // stride for perplexity calculations. If left at 0, the pre-existing approach will be used.
int ppl_output_type = 0; // = 0 -> ppl output is as usual, = 1 -> ppl output is num_tokens, ppl, one per line
Expand Down Expand Up @@ -277,8 +282,19 @@ float llama_embd_similarity_cos(const float * embd1, const float * embd2, int n)
// Control vector utils
//

// Load control vectors from a tuple of {path, strength}, scale each by strength, and add them together.
// Returns a tuple of {concatenated vector data (n_emnd x n_layer), n_embd}
// On error, returns a tuple of {empty, -1}
std::tuple<std::vector<float>, int> llama_control_vector_load(
const std::vector<std::tuple<std::string, float>> & vectors);
struct llama_control_vector_data {
int n_embd;

// stores data for layers [1, n_layer] where n_layer = data.size() / n_embd
std::vector<float> data;
};

struct llama_control_vector_load_info {
float strength;

std::string fname;
};

// Load control vectors, scale each by strength, and add them together.
// On error, returns {-1, empty}
llama_control_vector_data llama_control_vector_load(const std::vector<llama_control_vector_load_info> & load_infos);
22 changes: 11 additions & 11 deletions llama.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1877,7 +1877,7 @@ struct llama_control_vector {
std::vector<ggml_backend_buffer_t> bufs;

int32_t layer_start = 0;
int32_t layer_end = 0;
int32_t layer_end = 0;

ggml_tensor * tensor_for(int il) const {
if (il < 0 || il < layer_start || il > layer_end || (size_t) il >= tensors.size()) {
Expand Down Expand Up @@ -13183,6 +13183,10 @@ int32_t llama_n_embd(const struct llama_model * model) {
return model->hparams.n_embd;
}

int32_t llama_n_layer(const struct llama_model * model) {
return model->hparams.n_layer;
}

float llama_rope_freq_scale_train(const struct llama_model * model) {
return model->hparams.rope_freq_scale_train;
}
Expand Down Expand Up @@ -13335,7 +13339,7 @@ static bool llama_control_vector_init(struct llama_control_vector & cvec, const
return true;
}

int32_t llama_control_vector_apply(struct llama_context * lctx, float * data, size_t len, int n_embd, int32_t il_start, int32_t il_end) {
int32_t llama_control_vector_apply(struct llama_context * lctx, const float * data, size_t len, int32_t n_embd, int32_t il_start, int32_t il_end) {
const llama_model & model = lctx->model;
llama_control_vector & cvec = lctx->cvec;

Expand All @@ -13351,18 +13355,14 @@ int32_t llama_control_vector_apply(struct llama_context * lctx, float * data, si
}

cvec.layer_start = il_start;
cvec.layer_end = il_end;
cvec.layer_end = il_end;

for (size_t il = 1; il < model.hparams.n_layer; il++) {
if (il >= cvec.tensors.size() || cvec.tensors[il] == nullptr) {
continue;
}
size_t off = n_embd * (il - 1); // buffer doesn't have data for layer 0, since it's never present
assert(cvec.tensors[il] != nullptr);

const size_t off = n_embd * (il - 1); // buffer doesn't have data for layer 0, since it's never present
if (off + n_embd <= len) {
ggml_backend_tensor_set(cvec.tensors[il],
data + off,
0,
n_embd * ggml_element_size(cvec.tensors[il]));
ggml_backend_tensor_set(cvec.tensors[il], data + off, 0, n_embd * ggml_element_size(cvec.tensors[il]));
}
}

Expand Down
Loading

0 comments on commit 0a9bc30

Please sign in to comment.