Skip to content

Commit

Permalink
common : move back the penalties at the front of the sampling chain
Browse files Browse the repository at this point in the history
ggml-ci
  • Loading branch information
ggerganov committed Dec 13, 2024
1 parent f0849be commit a312568
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion common/common.h
Original file line number Diff line number Diff line change
Expand Up @@ -139,14 +139,14 @@ struct common_params_sampling {


std::vector<enum common_sampler_type> samplers = {
COMMON_SAMPLER_TYPE_PENALTIES,
COMMON_SAMPLER_TYPE_DRY,
COMMON_SAMPLER_TYPE_TOP_K,
COMMON_SAMPLER_TYPE_TYPICAL_P,
COMMON_SAMPLER_TYPE_TOP_P,
COMMON_SAMPLER_TYPE_MIN_P,
COMMON_SAMPLER_TYPE_XTC,
COMMON_SAMPLER_TYPE_TEMPERATURE,
COMMON_SAMPLER_TYPE_PENALTIES,
};

std::string grammar; // optional BNF-like grammar to constrain sampling
Expand Down
2 changes: 1 addition & 1 deletion examples/server/webui/src/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const CONFIG_DEFAULT = {
systemMessage: 'You are a helpful assistant.',
showTokensPerSecond: false,
// make sure these default values are in sync with `common.h`
samplers: 'dkypmxt',
samplers: 'edkypmxt',
temperature: 0.8,
dynatemp_range: 0.0,
dynatemp_exponent: 1.0,
Expand Down

0 comments on commit a312568

Please sign in to comment.