Skip to content

Commit

Permalink
ggml : remove redundant set of contexts used field (ggml/978)
Browse files Browse the repository at this point in the history
This commit removes the setting of the `used` field of the contexts in
the global state (g_state) in `ggml_init`.

The motivation for this change is that I believe that this additional
initialization might not be required after the changes in Commit
45fc4fed0b9fb5b1af4a8525cbebb95e11208732 ("sync : latest changes from
whisper.cpp"), which changed the initialization of the contexts field
from `{ 0 }` to `{ { 0 } }`:

```console
             g_state = (struct ggml_state) {
-                /*.contexts =*/ { 0 },
+                /*.contexts =*/ { { 0 } },
             };
```
My understanding is that the `{0}` initialization might not have
zero-initialized all the nested fields in every array element because of
compiler differences, and might have been the reason for having the
explicit setting of the `used` fields to false.
  • Loading branch information
danbev authored and ggerganov committed Oct 23, 2024
1 parent ac113a0 commit c19af0a
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions ggml/src/ggml.c
Original file line number Diff line number Diff line change
Expand Up @@ -3852,10 +3852,6 @@ struct ggml_context * ggml_init(struct ggml_init_params params) {
},
};

for (int i = 0; i < GGML_MAX_CONTEXTS; ++i) {
g_state.contexts[i].used = false;
}

const uint64_t t_end = ggml_time_us(); UNUSED(t_end);

GGML_PRINT_DEBUG("%s: g_state initialized in %f ms\n", __func__, (t_end - t_start)/1000.0f);
Expand Down

0 comments on commit c19af0a

Please sign in to comment.