Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. bug: Server Demo on Mac, safari return error #10841

Open
DickyQi opened this issue Dec 15, 2024 · 1 comment · May be fixed by #10857
Open

Misc. bug: Server Demo on Mac, safari return error #10841

DickyQi opened this issue Dec 15, 2024 · 1 comment · May be fixed by #10857

Comments

@DickyQi
Copy link

DickyQi commented Dec 15, 2024

Name and Version

5478bbc

Operating systems

Mac

Which llama.cpp modules do you know to be affected?

llama-server

Problem description & steps to reproduce

  1. build on MacBook Pro 16 inch 2019,
  2. run server demo
  3. open safari browser with localhost:8080
  4. type 'hello'

First Bad Commit

browser popup error dialog with message: "TypeError:r is not async iterable"

Relevant log output

srv  update_slots: all slots are idle
@bakkot
Copy link
Contributor

bakkot commented Dec 16, 2024

From a quick glance at the code I would guess this is because of these lines introduced in #10786 by @ngxson. That relies in ReadableStream being async iterable, which is not yet implemented in Safari.

@ngxson ngxson linked a pull request Dec 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants