Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Add llamma_ prefix in unicode.h unicode.cpp #10831

Closed
wants to merge 3 commits into from
Closed

Refactor: Add llamma_ prefix in unicode.h unicode.cpp #10831

wants to merge 3 commits into from

Conversation

MichelleTanPY
Copy link
Contributor

Make sure to read the contributing guidelines before submitting a PR

Description

Found TODO comment to add prefix for the unicode.h file, refactor - renaming struct and enum. No logic changed.

Changes Made

  • Update struct codepoint_flags to llama_codepoint_flags
  • Update enum in codepoint_flags to have llama_ prefix

Tests

  • Ran CI pipeline locally on branch. ✅

@ggerganov
Copy link
Owner

This TODO was outdated - the unicode source seems better to have it's own unicode_ prefix. I've pushed a PR to update this: #10838

@MichelleTanPY
Copy link
Contributor Author

@ggerganov Thanks for looking at this. Will close this PR then. Is there any TODOs/small refactor I can help with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichelleTanPY @ggerganov