Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Feature/refl cpp #4169

Closed

Conversation

jmikedupont2
Copy link

@jmikedupont2 jmikedupont2 commented Nov 22, 2023

WIP adding refl cpp
based on my previous cpp work. https://github.com/veselink1/refl-cpp provides a single header. I am experimenting with it, first version that compiled. Adding a new base class to everything, not sure if that is needd.

@jmikedupont2 jmikedupont2 marked this pull request as draft November 22, 2023 14:09
@jmikedupont2 jmikedupont2 changed the title Feature/refl cpp WIP Feature/refl cpp Nov 22, 2023
@FSSRepo
Copy link
Collaborator

FSSRepo commented Nov 22, 2023

Why did adding that model require changing the way parameters are assigned to structs? Just out of curiosity, I was struck by seeing 39 files changed just to add a model. It amuses me a bit because I sometimes do unnecessary things when I get excited 😂😂.

@jmikedupont2
Copy link
Author

jmikedupont2 commented Nov 22, 2023 via email

@jmikedupont2
Copy link
Author

jmikedupont2 commented Nov 22, 2023 via email

@jmikedupont2
Copy link
Author

So I have made progress on this, it turns out this lib needs a bunch of macros, I am working on the generator for them now.

@jmikedupont2
Copy link
Author

Screenshot_20231123_140723_Termux.jpg
Its working

@jmikedupont2
Copy link
Author

https://github.com/meta-introspector/llama.cpp/blob/feature/refl-cpp/binding.py this generator started to generate the bindings for me using a llvm and python

@jmikedupont2
Copy link
Author

https://github.com/meta-introspector/llama.cpp/blob/feature/refl-cpp/print.hpp this is the place where I put the generated wrappers

@jmikedupont2
Copy link
Author

#4209 now reworked the patch to be smaller

@jmikedupont2
Copy link
Author

Why did adding that model require changing the way parameters are assigned to structs? Just out of curiosity, I was struck by seeing 39 files changed just to add a model. It amuses me a bit because I sometimes do unnecessary things when I get excited 😂😂.

Now I reworked it to be much smaller patch please check it out #4209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants