Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove undeed header file. #6158

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Remove undeed header file. #6158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions examples/gguf-split/gguf-split.cpp
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know ggerganov hates when I make comments like this, but...

This file is missing #include <stdexcept> for std::invalid_argument. And it also has no reason to include <fcntl.h>, <ios>, or "llama.h".

Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@

#include <stdio.h>
#include <fcntl.h>
#include <unistd.h>
#include <string.h>
#include <unistd.h>

enum split_operation : uint8_t {
SPLIT_OP_SPLIT,
Expand Down
Loading