Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common, ngram_cache: added const reference for std::pair<> and std::tuple<> more 16 bytes: #7270

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

common, ngram_cache: added const reference for std::pair<> and std::tuple<> more 16 bytes: #7270

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ced5bfe
Added const reference for std::pair<> and std::tuple<> more 16 bytes:
GermanAizek May 14, 2024
ce4a390
Merge branch 'ggerganov:master' into const-ref-pair
GermanAizek May 20, 2024
f2e4d92
Added const reference for std::pair<> and std::tuple<> more 16 bytes:
GermanAizek May 20, 2024
2793b86
Merge branch 'master' into const-ref-pair
GermanAizek Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/ngram-cache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ void llama_ngram_cache_draft(

void llama_ngram_cache_save(llama_ngram_cache & ngram_cache, std::string & filename) {
std::ofstream file_out(filename, std::ios::binary);
for (std::pair<llama_ngram, llama_ngram_cache_part> item : ngram_cache) {
for (const std::pair<llama_ngram, llama_ngram_cache_part> & item : ngram_cache) {
const llama_ngram ngram = item.first;
llama_ngram_cache_part token_counts = item.second;
GGML_ASSERT(!token_counts.empty());
Expand Down Expand Up @@ -255,7 +255,7 @@ llama_ngram_cache llama_ngram_cache_load(std::string & filename) {
}

void llama_ngram_cache_merge(llama_ngram_cache & ngram_cache_target, llama_ngram_cache & ngram_cache_add) {
for (std::pair<llama_ngram, llama_ngram_cache_part> ngram_part : ngram_cache_add) {
for (const std::pair<llama_ngram, llama_ngram_cache_part> & ngram_part : ngram_cache_add) {
const llama_ngram ngram = ngram_part.first;
llama_ngram_cache_part part = ngram_part.second;

Expand Down
Loading