Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encoding in python scripts #7733

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Fix encoding in python scripts #7733

merged 1 commit into from
Jun 5, 2024

Conversation

Galunid
Copy link
Collaborator

@Galunid Galunid commented Jun 4, 2024

convert-hf-to-gguf.py shouldn't have any problems since encodings are manually specified where they are needed, but convert-hf-to-gguf-update.py was broken on windows.

fixes #7706

@github-actions github-actions bot added the python python script changes label Jun 4, 2024
@mofosyne mofosyne added the Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix label Jun 5, 2024
@Galunid Galunid requested a review from mofosyne June 5, 2024 15:47
@mofosyne mofosyne merged commit 7672ade into ggerganov:master Jun 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofosyne mofosyne mofosyne approved these changes

Assignees
No one assigned
Labels
python python script changes Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: convert-hf-to-gguf-update.py breaks in Windows Python 3.11.5
2 participants
@Galunid @mofosyne