-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add changes to handle jina v2 chinese code #7795
Open
JoanFM
wants to merge
57
commits into
ggerganov:master
Choose a base branch
from
JoanFM:feat-jina-embeddings-v2-zh
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+57
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-jina-v2-base-code
…t-jina-v2-base-code
…t-jina-v2-base-code
JoanFM
force-pushed
the
feat-jina-embeddings-v2-zh
branch
from
June 6, 2024 08:20
c8995a2
to
4dc0fe9
Compare
JoanFM
commented
Jun 6, 2024
JoanFM
force-pushed
the
feat-jina-embeddings-v2-zh
branch
from
June 6, 2024 08:31
4dc0fe9
to
605a619
Compare
ggerganov
reviewed
Jun 6, 2024
mofosyne
added
the
Review Complexity : Medium
Generally require more time to grok but manageable by beginner to medium expertise level
label
Jun 12, 2024
JoanFM
force-pushed
the
feat-jina-embeddings-v2-zh
branch
from
July 26, 2024 07:19
2cfcbbe
to
e2a91ef
Compare
…t-jina-embeddings-v2-zh
JoanFM
force-pushed
the
feat-jina-embeddings-v2-zh
branch
from
July 26, 2024 07:22
e2a91ef
to
201559d
Compare
Is this still working on? Jina models are great at rag scenario. And right now the models like cwchang/jina-embeddings-v2-base-zh in ollama will show errors without llama.cpp's support? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
python
python script changes
Review Complexity : Medium
Generally require more time to grok but manageable by beginner to medium expertise level
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the changes to handle Chinese model from Jina AI.
Changes description:
vocab
(This will be the most polemical change in the PR).Why those changes?
I think the relevant assertion is
GGML_ASSERT(vocab.id_to_token.size() == vocab.token_to_id.size());
, not sure it provides more value to have this extra restrictionlinefeed_id
that is not affecting inference at all.