Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Update README-sycl.md for Chapter "Recommended release" and "News" #7946

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

arthw
Copy link
Collaborator

@arthw arthw commented Jun 15, 2024

  • Self Reported Review Complexity:
    • Review Complexity : Low
    • Review Complexity : Medium
    • Review Complexity : High
  • I have read the contributing guidelines
  1. Add chapter "Recommended Release"
  2. Update the "News"

@arthw arthw requested a review from airMeng June 15, 2024 02:26
@github-actions github-actions bot added the SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language label Jun 15, 2024
README-sycl.md Outdated

|Commit ID|Tag|Release|
|-|-|-|
|fb76ec31a9914b7761c1727303ab30380fd4f05c|b3038 |[llama-b3038-bin-win-sycl-x64.zip](https://github.com/ggerganov/llama.cpp/releases/download/b3038/llama-b3038-bin-win-sycl-x64.zip) |
Copy link
Collaborator

@airMeng airMeng Jun 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luoyu-intel effectiveness on windows broken since this commit?

Copy link
Collaborator Author

@arthw arthw Jun 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test the win package and result is correct:
Download the zip file and decompress
Run the tools directly.

@mofosyne mofosyne added the Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix label Jun 16, 2024
README-sycl.md Outdated

The SYCL backend would be broken by some PRs due to no online CI.

Here is the releases with good quality:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more precise description

Suggested change
Here is the releases with good quality:
The following release is verified on GPU XXX/XXX/XXX with OneAPI xxx, Windows 11 xxx:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, add the hw/os/oneapi info in new column.

README-sycl.md Outdated Show resolved Hide resolved
@NeoZhangJianyu NeoZhangJianyu merged commit df68d4f into ggerganov:master Jun 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants