Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sched : offload_op also requires supports_op #7977

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

slaren
Copy link
Collaborator

@slaren slaren commented Jun 17, 2024

Check that the backend supports the operation before offloading it.

Fixes #7976

@stduhpf
Copy link
Contributor

stduhpf commented Jun 17, 2024

I can confirm it does fix the assert.

@slaren slaren merged commit 99052cd into master Jun 17, 2024
62 of 67 checks passed
@slaren slaren deleted the sl/sched-supports-offload branch June 17, 2024 14:51
@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ggml changes relating to the ggml tensor library for machine learning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Vulkan, I-quants partially working since PR #6210 (very slow, only with all repeating layers offloaded)
3 participants