Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download-release.sh for easy install #8044

Closed

Conversation

NickCrews
Copy link

I wanted an easy way to get llama-server on my machine.

I figured this would be useful for other people as well.

Take a look at the docstring and help text, it should be fairly intuitive.

Tested as working on a mac m1. The path handling only works with unixy paths for now, sorry windows people. If you want, this is ripe for improving in this regard.

I tried to keep portability in mind besides that though, though I'm no shell expert.

@NickCrews NickCrews force-pushed the download-release-script branch from 94a30e6 to dcd0442 Compare June 20, 2024 22:52
@ggerganov
Copy link
Owner

Should be moved to the scripts folder

@mofosyne mofosyne added the Review Complexity : Medium Generally require more time to grok but manageable by beginner to medium expertise level label Jun 21, 2024
@NickCrews
Copy link
Author

Will do. Any other top-level comments? Is this even something you want to consider?

I also noticed now scripts/server-llm.sh. This has some duplicate functionality with that, since that also installs llama-server, it just does it by building it instead of downloading a release. Perhaps we want to split this into three scripts?

  • download-build.sh
  • download-release.sh
  • run-server.sh

You can choose whichever download- script you need, and then run-server.sh? Idk this might have to be breaking, but we might be able to keep it non-breaking.

Or other option would be to merge everything into a mega script, adding this functionality to llm-server.sh, toggleable with a flag?

@NickCrews NickCrews force-pushed the download-release-script branch from dcd0442 to ea325e0 Compare June 24, 2024 04:28
@github-actions github-actions bot added the script Script related label Jun 24, 2024
I wanted an easy way to get llama-server on my machine.

I figured this would be useful for other people as well.

Take a look at the docstring and help text, it should be fairly intuitive.

Tested as working on a mac m1. The path handling only works with unixy paths for now, sorry windows people.
If you want, this is ripe for improving in this regard.

I tried to keep portability in mind besides that though, though I'm no shell expert.
@NickCrews NickCrews force-pushed the download-release-script branch from ea325e0 to a682156 Compare June 24, 2024 04:41
@ggerganov
Copy link
Owner

It's best if the option is merged into the existing llm-server.sh script

@NickCrews
Copy link
Author

I'm just going to close as stale, turns out I didn't need this that badly :) Feel free to push this over the finish line if anyone is interested.

@NickCrews NickCrews closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Complexity : Medium Generally require more time to grok but manageable by beginner to medium expertise level script Script related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants