Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI failures #8066

Merged
merged 2 commits into from
Jun 23, 2024
Merged

fix CI failures #8066

merged 2 commits into from
Jun 23, 2024

Conversation

slaren
Copy link
Collaborator

@slaren slaren commented Jun 22, 2024

Patches for common intermittent CI failures in test-backend-ops with CPY and server.yml with thread sanitizer.

@github-actions github-actions bot added testing Everything test related devops improvements to build systems and github actions labels Jun 22, 2024
@slaren
Copy link
Collaborator Author

slaren commented Jun 22, 2024

@ggerganov it looks like github has an option to prevent merging PRs if the CI is failing. Please consider enabling this, at the very least for the most basic checks such as editorconfig and linting.

image

@ngxson
Copy link
Collaborator

ngxson commented Jun 22, 2024

@slaren I'm not against this idea, seems like very useful thing since sometimes I overlook small changes.

However, I'm thinking that some jobs should be consider to be "OK to fail". For example "Publish Docker" sometimes fails for unknown reason (mostly due to external error), and when re-run it takes quite a lot of time.

@ggerganov
Copy link
Owner

Added the branch requirements:

image

@slaren slaren merged commit b6b9a8e into master Jun 23, 2024
62 of 65 checks passed
@slaren
Copy link
Collaborator Author

slaren commented Jun 23, 2024

I am not sure if the checks are working, it shouldn't have allowed me to merge this.

@slaren slaren deleted the sl/fix-ci branch June 23, 2024 11:15
@ggerganov
Copy link
Owner

I had forgotten to save the settings page today. Just applied the change now and it should be active

arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jun 30, 2024
* test-backend-ops : increase cpy max nmse

* server ci : disable thread sanitizer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops improvements to build systems and github actions testing Everything test related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants