CI: fix release build (Ubuntu+Mac) #8170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR ggerganov#8006 changes defaults to build shared libs. However, CI for releases expects static builds.
|
Likely only the windows builds correctly add the shared libraries in the release. The rest should be disabled, or fixed so that the shared library is added to the artifact. |
That's my assumption too, but as I don't have access to other platforms to test, this PR is just for Linux. edit: had a colleague test Mac so added fix for Mac as well. |
loonerin
changed the title
github-actions
bot
added
the
devops
slaren
approved these changes
Jun 27, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Jun 30, 2024
* CI: fix release build (Ubuntu) PR ggerganov#8006 changes defaults to build shared libs. However, CI for releases expects static builds. * CI: fix release build (Mac) --------- Co-authored-by: loonerin <[email protected]>
MagnusS0
pushed a commit
to MagnusS0/llama.cpp-normistral-tokenizer
that referenced
this pull request
Jul 1, 2024
* CI: fix release build (Ubuntu) PR ggerganov#8006 changes defaults to build shared libs. However, CI for releases expects static builds. * CI: fix release build (Mac) --------- Co-authored-by: loonerin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #8006 changes defaults to build shared libs. However, CI for releases expects static builds.
Other platforms likely need the same change.