cmake : fix deprecated option names not working #8171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
changed the title
ggerganov
approved these changes
Jun 27, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Jun 30, 2024
* cmake : fix deprecated option names not working * remove LlAMA_OPENMP
MagnusS0
pushed a commit
to MagnusS0/llama.cpp-normistral-tokenizer
that referenced
this pull request
Jul 1, 2024
* cmake : fix deprecated option names not working * remove LlAMA_OPENMP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecated options are not working correctly because the variables are not being set in the correct scope.
LLAMA_OPENMPalso cannot work as is because the default isON, but the wayllama_option_deprworks, it only works when enabling an option, but not when disabling it. I removed it to avoid confusion.