Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing items in makefile #8177

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Add missing items in makefile #8177

merged 1 commit into from
Jun 28, 2024

Conversation

ngxson
Copy link
Collaborator

@ngxson ngxson commented Jun 27, 2024

  • Missing common/*.o in make clean
  • Missing tests/test-chat-template in TEST_TARGETS

@ngxson ngxson added the Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix label Jun 27, 2024
@ngxson ngxson requested a review from mofosyne June 27, 2024 22:19
@slaren slaren merged commit a27aa50 into ggerganov:master Jun 28, 2024
53 checks passed
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jun 30, 2024
@ngxson @NeoZhangJianyu
Add missing items in makefile (ggerganov#8177)
158f7c9
MagnusS0 pushed a commit to MagnusS0/llama.cpp-normistral-tokenizer that referenced this pull request Jul 1, 2024
@ngxson @MagnusS0
Add missing items in makefile (ggerganov#8177)
9b2b5d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaren slaren slaren approved these changes

@mofosyne mofosyne Awaiting requested review from mofosyne

Assignees
No one assigned
Labels
Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngxson @slaren