clip: don't throw exceptions from llava functions compiled as extern "C" #8210
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofosyne
added
the
Review Complexity : Low
slaren
reviewed
Jun 30, 2024
Comment on lines
+2084
to
+2085
| LOG_TEE("%s: don't support projector with: %s currently\n", __func__, proj_type.c_str()); | ||
| return 0; |
There was a problem hiding this comment.
This should never happen since the projector type is already checked when loading the model, right? If that's the case, it would be better to use an assert here, since returning zero would allow applications to continue without catching the error, and this should never happen unless there is a bug somewhere else anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #7073