Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clib.json to point to Cyan4973 original xxhash repo #8491

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

mofosyne
Copy link
Collaborator

Convinced Cyan4973 to add clib.json directly to his repo, so can now point the clib package directly to him now. Previously pointed to my fork with the clib.json package metadata

Cyan4973/xxHash#954

Convinced Cyan4973 to add clib.json directly to his repo, so can now point the clib package directly to him now. Previously pointed to my fork with the clib.json package metadata

Cyan4973/xxHash#954
@mofosyne mofosyne added the Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix label Jul 15, 2024
@mofosyne mofosyne force-pushed the mofosyne-gguf-clib-patch branch from 20439fc to 743d89f Compare July 15, 2024 11:54
@mofosyne mofosyne added the merge ready indicates that this may be ready to merge soon and is just holding out in case of objections label Jul 15, 2024
@mofosyne mofosyne force-pushed the mofosyne-gguf-clib-patch branch from 743d89f to 78eff8b Compare July 15, 2024 13:21
@mofosyne
Copy link
Collaborator Author

@ggerganov thanks for the quick approve, but something seems a bit stuck with the cicd 'Expected — Waiting for status to be reported ', even though its marked as noci

@ggerganov ggerganov merged commit 1666f92 into master Jul 16, 2024
1 check passed
@ggerganov ggerganov deleted the mofosyne-gguf-clib-patch branch July 16, 2024 07:14
@ggerganov
Copy link
Owner

@ggerganov thanks for the quick approve, but something seems a bit stuck with the cicd 'Expected — Waiting for status to be reported ', even though its marked as noci

Not sure why these didn't run - maybe Github is acting up

@slaren
Copy link
Collaborator

slaren commented Jul 16, 2024

CI should not be disabled for documentation changes. The editorconfig and lint checks must pass before a PR can be merged, and that includes documentation-only changes. If documentation changes are allowed to be merged without these checks, then they can leave the build in master broken and cause all following PRs to fail the check. Most workflows are already skipped if there are no code changes.

arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 27, 2024
…nov#8491)

* Update clib.json to point to Cyan4973 original xxhash

Convinced Cyan4973 to add clib.json directly to his repo, so can now point the clib package directly to him now. Previously pointed to my fork with the clib.json package metadata

Cyan4973/xxHash#954

* gguf-hash: readme update to point to Cyan4973 xxHash repo [no ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples merge ready indicates that this may be ready to merge soon and is just holding out in case of objections Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants