Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert-*.py: add general.name kv override #8571

Merged
merged 1 commit into from
Jul 19, 2024
Merged

convert-*.py: add general.name kv override #8571

merged 1 commit into from
Jul 19, 2024

Conversation

mofosyne
Copy link
Collaborator

Looks like I missed a line that would allow for overriding general.name in authorship metadata

@mofosyne mofosyne added the Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix label Jul 18, 2024
@github-actions github-actions bot added the python python script changes label Jul 18, 2024
@mofosyne mofosyne requested a review from compilade July 18, 2024 20:48
@mofosyne mofosyne merged commit 3d0e436 into ggerganov:master Jul 19, 2024
8 checks passed
@mofosyne mofosyne deleted the convert-py-missing-kv-name-override branch July 19, 2024 07:52
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 27, 2024
@mofosyne @arthw
convert-*.py: add general.name kv override (ggerganov#8571)
fa91d86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compilade compilade compilade approved these changes

Assignees
No one assigned
Labels
python python script changes Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mofosyne @compilade