Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gguf : handle null name during init #8587

Merged
merged 1 commit into from
Jul 20, 2024
Merged

gguf : handle null name during init #8587

merged 1 commit into from
Jul 20, 2024

Conversation

ggerganov
Copy link
Owner

fix #8583

Do not strcmp if we failed earlier

@github-actions github-actions bot added examples ggml changes relating to the ggml tensor library for machine learning labels Jul 19, 2024
HanClinto
HanClinto approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@HanClinto HanClinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@mofosyne mofosyne added Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix merge ready indicates that this may be ready to merge soon and is just holding out in case of objections labels Jul 19, 2024
@ggerganov ggerganov merged commit 07283b1 into master Jul 20, 2024
54 checks passed
@Arashimu
Copy link

fix #8583

Do not strcmp if we failed earlier

Could I get a CVE of this issue?

arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 27, 2024
@ggerganov @arthw
gguf : handle null name during init (ggerganov#8587)
c3ca2aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HanClinto HanClinto HanClinto approved these changes

Assignees
No one assigned
Labels
examples ggml changes relating to the ggml tensor library for machine learning merge ready indicates that this may be ready to merge soon and is just holding out in case of objections Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: null pointer defer in gguf_init_from_file
4 participants
@ggerganov @Arashimu @HanClinto @mofosyne